Home     About

The First Reviewer

be the first reviewer of your patches, and don't just push them as a responsibility for others. it's your duty to ensure the correctness of your patches to the highest degree. often there are comments and assumptions which go unnoticed when working on the issue, but as soon as the patch is pushed, you have an opportunity to look at the patch from a distance, from a high level. then you disconnect from that code as being yours and ask meaningful questions

then you would be able to ask questions on what does this comment mean, oh, is thmight be an edge case, is it taken care of somewhere else?? or what about is thstring comparison, couldn't we have used enum here? other questions like at thon the design decisions also also worth asking.

over time you develop instincts to do these things beforehand, and the reviewers don't have to then stress over silly mistakes that you could have fixed.